Skip to content

Conversation

@gsulc
Copy link
Contributor

@gsulc gsulc commented Jan 31, 2020

I haven't been able to test this, but this change should fix these issues. I should be able to test them at some point next week, but it would be good to start the review process and get any early feedback.

Copy link
Collaborator

@af-silva af-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems ok for me, I will wait your feedback. I don't have access right now to hardware to test, maybe in two weeks I will have access and can give feedback there.

Thanks for the work @gsulc

@gsulc
Copy link
Contributor Author

gsulc commented Feb 8, 2020

Gah. Sorry. Next week. I have hardware at work, but other things are taking priority even though I'm utilizing this project.

@yyjpeter
Copy link

yyjpeter commented Sep 7, 2021

canopen

@af-silva
Copy link
Collaborator

The state transitions were updated in #264.
I will close this for now, if the new implementations don't solve this problem the transitions for a specific device should be handle by user code.
Any suggestion, please say so.
Thanks.

@af-silva af-silva closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants