Adding retransmit functionnality to sdo block download #324
Conversation
christiansandberg
left a comment
christiansandberg
left a comment
There was a problem hiding this comment.
Thanks for this PR!
canopen/sdo/client.py
Outdated
| "Will start retransmission") % (ackseq, self._blksize)) | ||
| # Sub blocks betwen ackseq and end of corrupted block need to be resent | ||
| # Copy block to resend, and clear it so that multiple retransmits can be done | ||
| block = self._current_block[ackseq:].copy() |
There was a problem hiding this comment.
I believe just subindexing a list will return a copy already.
There was a problem hiding this comment.
Yes you are absolutely right !
canopen/sdo/client.py
Outdated
| "block download response") | ||
| if ackseq != self._blksize: | ||
| # Sequence error, try to retransmit | ||
| self.sdo_client.abort(0x05040003) |
There was a problem hiding this comment.
I don't quite remember the spec, is this abort code still needed?
There was a problem hiding this comment.
This is taken from the spec and apparently an SDO abort is only necessary in case of a fatal error, so I will remove it.
However it still worked with this abort message, so we probably have a bug on our side.
There was a problem hiding this comment.
No it's not very common for clients to send abort codes to the server, so some servers may just ignore them.
There was a problem hiding this comment.
Ok, good to know.
…ly be sent if an error is unrecoverable
2 participants
I am submitting a pull request to add retransmission functionnality for sdo block download.
I faced a hardware issue (silicon errata) on a DSP where in some very rare cases the CAN rx fifo would swap the reception of two or more CAN frames causing the block transfer to fail, this was a nice solution to overcome the problem.