Check data length sdo server #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly be sent if an error is unrecoverable
…alue - Added test
christiansandberg
approved these changes
Dec 9, 2022
Member
christiansandberg
left a comment
christiansandberg
left a comment
There was a problem hiding this comment.
Thanks, looks reasonable.
acolomb
approved these changes
Dec 10, 2022
Member
|
I guess the automated checks need some attention, though nothing related to the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if writing a value with the wrong size inside object dictionary, no errors are raised.
This can cause all sorts of problem : for example when sending PDO frames, the frame could be greater than 8 bytes, etc.
I added a a length check when the expected datatype is of NUMBER_TYPE.