Use with contexts for open #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolomb
reviewed
Mar 25, 2023
Member
acolomb
left a comment
acolomb
left a comment
There was a problem hiding this comment.
Looks good overall from a quick glance. I guess if people relied on these functions closing their file handle for them, that's rather weird, but was it documented? I can't imagine many cases where it would matter, but let's hear some more thoughts on whether this behavior change needs a bit of a migration path to avoid breaking existing code on upgrade.
christiansandberg
approved these changes
Apr 1, 2023
Collaborator
Author
|
I see the PR is approved. Is this PR waiting on any input or action from me? |
sveinse
commented
Apr 6, 2023
Collaborator
Author
There was a problem hiding this comment.
A small snag: Since this PR was created before the isinstance() fix was merged, this PR was created with type(). This statement should ideally be changed to ensure proper isinstance() use:
# If dest is opened in this fn, it should be closed
if isinstance(dest, str):
dest.close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
withcontexts to the usage of open. A context handles closing automatically, making the call to close superfluous.Ths PR also fixes issue with close in objectdictionary/init.py and eds.py.
export_od()andimport_eds()should not close file handles that is not opened within these functions.