Implement reading PDO from OD defaults (#273) #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, I did something similar on my side for two main reasons (just putting this for explanation):
Anyway, cool improvement ! |
acolomb
reviewed
May 2, 2023
Member
acolomb
left a comment
acolomb
left a comment
There was a problem hiding this comment.
Nice addition. Only one nit-pick comment.
| """Read PDO configuration for this map using SDO.""" | ||
| cob_id = self.com_record[1].raw | ||
|
|
||
| def _raw_from(param): |
Member
There was a problem hiding this comment.
Do we need an underscore name here? The function is only defined within this scope, so there is nothing to be gained by trying to hide it?
Collaborator
Author
There was a problem hiding this comment.
No, not really. Only a convention. My habit is to name functions that are defined within a fn or meth using a underscore prefix, but it is not necessity.
Member
|
And I think this needs documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small improvement based on discussion in #273 that allows reading the PDO configuration from the object dictionary defaults rather than requesting them from the remote node.