SDO client fixes #408
Merged
SDO client fixes #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also synchronous RPDOs should now be transmitted on sync reception Need to add more tests for this last part
…#345) * Fixed incorrect min (LowLImit) and max (HighLimit) values when using signed integer types. * Fixed min/max for non-signed datatypes and added tests * Removed type hints
…case of abort Added missing aborts : - One for timeout at beginning of comm - One for re-transmit timeout - The one with the different received index/subindex than requested is not considered so that it doesn't break an ongoing comm with another client
This reverts commit 074be34.
acolomb
approved these changes
Apr 17, 2024
Member
acolomb
left a comment
acolomb
left a comment
There was a problem hiding this comment.
I haven't really tested these changes in production, but I did notice the same error on a real bus lately. Your fix looks sensible and I think it should work as intended.
@christiansandberg I'll wait on your veto for one week before merging.
jonastittmannpinion
pushed a commit
to PinionGmbH/canopen
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 0e6e510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
During some testing I noticed some strange behaviour of the sdo client. ==> during block transfer it sends the "end block" after aborting.
I made adjustments to the sdo client block upload : do not send the "end" block if there was an abort, client side.
Also added some missing aborts.
I think there some other small implementation errors here and there that I will try to send PRs for.