Mirror some OD access API to the SdoBase / SdoVariable classes #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ultimate goal here is being able to switch from a "live" mode to an "offline" mode by accessing either the SDO client or the object dictionary while accessing the same methods. The convenient get_variable() method is mirrored from the OD, raising no exceptions and encapsulating the two-staged access for sub-objects in records or arrays. The writable and readable properties on an SdoVariable are simply passed through to the underlying OD properties. This is solely a convenience to match the ODVariable API without having to mention the internal sdo_var.od attribute.
jonastittmannpinion
pushed a commit
to PinionGmbH/canopen
that referenced
this pull request
Apr 30, 2024
…pen-python#423) (cherry picked from commit dc8a4ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate goal here is being able to switch from a "live" mode to an "offline" mode by accessing either the SDO client or the object dictionary while accessing the same methods.
The convenient
get_variable()method is mirrored from the OD, raising no exceptions and encapsulating the two-staged access for sub-objects in records or arrays.The
writableandreadableproperties on anSdoVariableare simply passed through to the underlying OD properties. This is solely a convenience to match theODVariableAPI without having to mention the internalsdo_var.odattribute.