EMCY Error Logging #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds error reset and other xx00h errors to the log list. Clearing the active list once error reset is received still holds true but all errors are now logged.
Fix emcy error logging
Since error reset is logged, increment log list.
| self.active.append(entry) | ||
| self.emcy_received.notify_all() | ||
|
|
||
| if code & 0xFFFF == 0: |
Member
There was a problem hiding this comment.
I see that I made a mistake masking out the lower byte when I actually meant to mask out the higher byte as specified here for example (reset = 00xx). So I think it should be:
if code & 0xFF00 == 0:
Contributor
Author
There was a problem hiding this comment.
Agreed. Sorry, I did not check DS-301 error codes.
| # Error reset | ||
| self.active = [] | ||
| for callback in self.callbacks: | ||
| callback(None) |
Member
There was a problem hiding this comment.
I'm thinking it may be better skip using None as a representation for reset and just use the same emcy object regardless if it is a reset or an actual error. Then you can get timestamp for the reset and so on. What do you think? Then the documentation would have to be changed slightly as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.