Revert "change missing Baudrate to BaudRate" #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CiA 306 CANopen electronic data sheet (EDS) standard is quite clear that in the DeviceCommisioning block, baudrate is spelled 'Baudrate' and not 'BaudRate'. This commit is to be reverted, as it prevents loading of standards compliant DCF files. Chapter 5.3.3.3 is clear in the casing of Baudrate for DeviceCommisioning and BaudRate for DeviceInfo. This seems to be an inconcistency in the standard, and we should probably accept both as a long term solution. This reverts commit 074cbbc.
acolomb
approved these changes
Jun 4, 2024
acolomb
added a commit
to acolomb/canopen
that referenced
this pull request
Jun 4, 2024
As pointed out in canopen-python#452, there is an inconsistency in the CiA 306 spec regarding the exact spelling. Under DeviceComissioning (sic!), it is spelled with a lowercase "r", while under DeviceInfo it is BaudRate_* with an uppercase "R". That change however broke the tests, because the library currently handles keys in a case-sensitive way (which is wrong in itself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CiA 306 CANopen electronic data sheet (EDS) standard is quite clear that in the DeviceCommisioning block, baudrate is spelled 'Baudrate' and not 'BaudRate'. This commit is to be reverted, as it prevents loading of standards compliant DCF files.
Chapter 5.3.3.3 is clear in the casing of Baudrate for DeviceCommisioning and BaudRate for DeviceInfo. This seems to be an inconcistency in the standard, and we should probably accept both as a long term solution.
This reverts commit 074cbbc.
This fixes #347 its duplicate #450