-
Notifications
You must be signed in to change notification settings - Fork 220
Increase export_eds() test coverage #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase export_eds() test coverage #474
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 67.68% 67.84% +0.16%
==========================================
Files 26 26
Lines 3104 3104
Branches 521 521
==========================================
+ Hits 2101 2106 +5
+ Misses 862 859 -3
+ Partials 141 139 -2 |
|
Moreover, don't shadow |
|
I expanded the scope of the PR with 083c24c; I've split up the tests in multiple test functions, for easier debugging in case one of them fails. I also used |
|
Waiting for #476, as that will change the raised exception type. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Ouch, I seem to have introduced a temporary file mess when running the tests. Sorry 'bout that; I'll create a PR to ensure tests are properly cleaned up. |
No description provided.