Skip to content

Conversation

@acolomb
Copy link
Member

@acolomb acolomb commented Jul 3, 2024

The CiA306 spec is not quite clear on which fields are mandatory within the DeviceComissioning section. Thus it should be assumed that the two options handled here could be missing. Instead of raising an exception, ignore the absence of the Baudrate setting.

The CiA306 spec is not quite clear on which fields are mandatory
within the DeviceComissioning section.  Thus it should be assumed that
the two options handled here could be missing.  Instead of raising an
exception, ignore the absence of the Baudrate setting.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (6a4ca11) to head (96b2f0c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   67.84%   67.82%   -0.03%     
==========================================
  Files          26       26              
  Lines        3107     3108       +1     
  Branches      524      525       +1     
==========================================
  Hits         2108     2108              
  Misses        859      859              
- Partials      140      141       +1     
Files Coverage Δ
canopen/objectdictionary/eds.py 83.66% <50.00%> (-0.25%) ⬇️

@acolomb acolomb merged commit f1315d3 into canopen-python:master Jul 3, 2024
@acolomb acolomb deleted the bitrate-optional branch July 3, 2024 22:28
@erlend-aasland
Copy link
Contributor

I added tests for this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants