Add back PdoBase.export() dependency (canmatrix) #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canmatrix optional dependency was removed on Oct 10, 2021 with commit c46228f. It is now added back as an optional dependency, using the same name as previously: db_export. To install the dependency: $ python3 -m pip install 'canopen[db_export]' Resolves canopen-python#488
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 67.71% 67.90% +0.19%
==========================================
Files 26 26
Lines 3113 3116 +3
Branches 527 527
==========================================
+ Hits 2108 2116 +8
+ Misses 864 858 -6
- Partials 141 142 +1
|
erlend-aasland
commented
Jul 3, 2024
Contributor
Author
|
FTR, I reused the same feature specifier as before: |
erlend-aasland
commented
Jul 3, 2024
acolomb
requested changes
Jul 6, 2024
- skip test from within the test method - raise NotImplementedError from within the export() method
acolomb
approved these changes
Jul 8, 2024
Member
|
Please fix the conflicts, otherwise ready to merge. |
acolomb
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canmatrix optional dependency was removed on Oct 10, 2021 with commit
c46228f. It is now added back as an optional dependency, using the same
name as previously: db_export.
To install the dependency:
$ python3 -m pip install 'canopen[db_export]'
Resolves #488