Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

Wait a little bit longer before dispatching the EMCY packet, and start
the one-shot timer just before invoking the wait() call.

Wait a little bit longer before dispatching the EMCY packet, and start
the one-shot timer just before invoking the wait() call.
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.10%. Comparing base (83594ac) to head (041888c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files          26       26           
  Lines        3111     3111           
  Branches      526      526           
=======================================
  Hits         2212     2212           
  Misses        769      769           
  Partials      130      130           

@acolomb
Copy link
Member

acolomb commented Aug 12, 2024

I'll just run the checks a few times now before merging.

@erlend-aasland
Copy link
Contributor Author

I'll just run the checks a few times now before merging.

Hold it a little bit; I'd like to also add resource management (joining).

@acolomb acolomb merged commit 4301c4b into canopen-python:master Aug 12, 2024
@erlend-aasland erlend-aasland deleted the test/harden-emcy-wait branch August 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants