Make Network.notifier timeouts customizable (fixes #530) #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the hard-coded 1 second maximum cycle duration passed during can.Notifier construction to a class variable NOTIFIER_CYCLE. Explicitly specify the timeout to stop the notifier in another class variable NOTIFIER_SHUTDOWN_TIMEOUT, matching the default used in python-can. These can be overridden per instance if needed.
Explicitly set the NOTIFIER_SHUTDOWN_TIMEOUT to zero in all Network instances created for unit tests. This reduces total test running time from ~30 to ~9 seconds when run locally.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 71.10% 71.12% +0.01%
==========================================
Files 26 26
Lines 3111 3113 +2
Branches 526 526
==========================================
+ Hits 2212 2214 +2
Misses 769 769
Partials 130 130
|
Member
Author
|
@erlend-aasland this should replace #535. Note that the actual time for the tests alone varies between 9 and 47 seconds on my machine. It seems the NMT tests timings are not very reproducible mainly. That also explains why this PR is a bit quicker for one check (34 s), but slower for the other (50 s) than the alternative #535. |
acolomb
changed the title
Contributor
|
You beat me; I was working on a similar PR based on your suggestion 😄 This looks nice! |
erlend-aasland
approved these changes
Aug 14, 2024
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the hard-coded 1 second maximum cycle duration passed during
can.Notifierconstruction to a class variableNOTIFIER_CYCLE.Explicitly specify the timeout to stop the notifier in another class
variable
NOTIFIER_SHUTDOWN_TIMEOUT, matching the default used inpython-can. These can be overridden per instance if needed.
Do not wait for notifier thread shutdown during tests by explicitly setting the
NOTIFIER_SHUTDOWN_TIMEOUTto zero in allNetworkinstances created for unit tests.This reduces total test running time from ~30 to ~9 seconds when run locally.