feat: multi sync example#1622
Draft
Viktor-Kalashnykov-da wants to merge 52 commits into
Draft
Conversation
jarekr-da
reviewed
Apr 17, 2026
jarekr-da
reviewed
Apr 17, 2026
jarekr-da
reviewed
Apr 17, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
reviewed
Apr 21, 2026
jarekr-da
requested changes
Apr 21, 2026
jarekr-da
reviewed
Apr 22, 2026
…for examples and added ID of TransferFactory from this project in Exmple 15. Also removed buildContractReadSpec() and its usages Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…global during settlement of Trade Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…to Ledger Namespace Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…s of Wallet SDK Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Author
|
The changes done:
TODO:
|
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…at could happen in unassign method Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Author
|
Further changes done:
Unification of single-sync and multi-sync tests is in progress on another PR |
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: Viktor-Kalashnykov-da <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
tudor-da
reviewed
May 28, 2026
| * | ||
| * Unlike {@link DarNamespace.upload}, this function always POSTs the DAR to | ||
| * the ledger API regardless of whether the package bytes have already been | ||
| * uploaded on another synchronizer. The server deduplicates the binary |
There was a problem hiding this comment.
The upload is not done against a synchronizer, but the vetting that is done as part of it is, please clarify
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…ade Settlement error Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
…enamed to vetDar() Signed-off-by: vkalashnykov <viktor.kalashnykov@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-Synchronizer DvP Example - On ledger API - Part 1
Showcaces automatic reassignment of Token from private synchronizer to global one
There are 2 follow up PRs (wip)
Technical limitations:
In this PR we introduce separate tests for multi-sync (otherwise regular tests are flaky on multi-sync) - that split will be removed in a separate PR (above)
New example script:
docs/wallet-integration-guide/examples/scripts/15-multi-sync-trade.ts
Note on explicit reassignment
we experimented with automatic reassignment of contracts - and it basically worked BUT.
It worked as long as
Bobis owner ofTokenRulescontract which seems unrealistic.We introduced TokenAdmin as additional party that is issuer of
Tokenonapp-synchronizer(private one).But this in fact forces us to use explicit reassignment.