fix: transform mixed esm modules#1910
Merged
Merged
Conversation
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
alexmatson-da
approved these changes
May 29, 2026
Contributor
alexmatson-da
left a comment
alexmatson-da
left a comment
There was a problem hiding this comment.
if you havent yet, maybe worth testing the bundle by running some local web server (like python -m http.server) from the dist/ directory. If that works, then i'm reasonably confident the image should work
Contributor
Author
@alexmatson-da I actually went further and built a docker image using a similar Dockerfile in the infra repo. Ran it on port 3333, added 3333 for cors to WG and tested a simple flow. All worked well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.