Print detailed database difference report in tests for easier debugging#770
Merged
zariiii9003 merged 2 commits intocantools:masterfrom Dec 18, 2025
Merged
Print detailed database difference report in tests for easier debugging#770zariiii9003 merged 2 commits intocantools:masterfrom
zariiii9003 merged 2 commits intocantools:masterfrom
Conversation
Pull Request Test Coverage Report for Build 20319516101Details
💛 - Coveralls |
andlaus
approved these changes
Dec 17, 2025
| b_attr = getattr(b, name) | ||
| if callable(a_attr) or callable(b_attr): | ||
| continue | ||
| if type(a_attr) is not type(b_attr): |
Member
There was a problem hiding this comment.
isn't that already covered by the if statement on line 184?
Collaborator
Author
There was a problem hiding this comment.
Yes, that can be removed
|
|
||
| a_attr = getattr(a, name) | ||
| b_attr = getattr(b, name) | ||
| if callable(a_attr) or callable(b_attr): |
Member
There was a problem hiding this comment.
I suppose that if one of these attributes is callable, but the other is not, a diff should be added.
Collaborator
Author
There was a problem hiding this comment.
I'll move it outside the for loop below the type check. The diff entry shouldn't be necessary then as that case will be caught by the type comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new test with some
# TODOcomments, some of which i will address in a follow-up PR.