Internationalization support for error messages #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
sdm/src/test/java/unit/com/sap/cds/sdm/service/handler/SDMServiceGenericHandlerTest.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/unit/com/sap/cds/sdm/service/handler/SDMAttachmentsServiceHandlerTest.java
Fixed
Show fixed
Hide fixed
sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMAttachmentsServiceHandler.java
Fixed
Show fixed
Hide fixed
sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMServiceGenericHandler.java
Fixed
Show fixed
Hide fixed
sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMServiceGenericHandler.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/unit/com/sap/cds/sdm/service/handler/SDMAttachmentsServiceHandlerTest.java
Fixed
Show fixed
Hide fixed
sdm/src/test/java/unit/com/sap/cds/sdm/service/handler/SDMServiceGenericHandlerTest.java
Fixed
Show fixed
Hide fixed
sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMAttachmentsServiceHandler.java
Fixed
Show fixed
Hide fixed
sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMServiceGenericHandler.java
Fixed
Show fixed
Hide fixed
This reverts commit a1912ba.
rishikunnath2747
removed
the
Under Construction
yashmeet29
previously approved these changes
Dec 26, 2025
yashmeet29
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for consumer applications to translate the error messages propagated by the SDM plugin
The error messages are fetched based on the application language settings and cached when ReadAttachmentsHandler runs
Subsequently it fetches all the translated error messages from the cache
In case the consumer application doesn't define translated error messages, it defaults to the error messages provided in the SDMErrorMessages class in english
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested
Single tenant : https://github.com/cap-java/sdm/actions/runs/20517677888/job/58947951889
Multi tenant : https://github.com/cap-java/sdm/actions/runs/20517682015/job/58949765104