Skip to content

Prepare PoC for generic upload of TypeInstances even if Action failed #563

@mszostok

Description

@mszostok

Description

Prepare PoC for generic upload of TypeInstances even if Action failed.

Currently, the upload TypeInstance step is the last one, and it's executed only if all other step exited with non-zero code.
This is problematic as in case of failed Action we don't have TypeInstances generated in previous steps.

AC

Even if Action fails:

  1. TypeInstances from successfully finished steps are uploaded to Local Hub
  2. We still built the relations between uploaded TypeInstances (as much as we can, ignoring missing TypeInstances)
  3. We see uploaded TypeInstance under Action status (.Actions[0].output.typeInstances).

Reason

To get the output of executed step (TypeInstances) for failed Action we need to download it directly from MinIO. It requires a lot of manual steps. Additionally, it generates a second problem, sometimes the format of artifacts from MinIO are different from the final TypeInstances format.

This enables also a rollback (#502) for failed Action too.

Use cases

  • System User - enables and option to easily get the output of executed step from failed Action, e.g., to download the Terraform state and execute clean-up.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/cliRelates to CLIarea/documentationRelated to all activities around documentationarea/engineRelates to Enginearea/hubRelates to HubenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions