Add name for each query and mutation in Hub Go client#378
Merged
mszostok merged 2 commits intocapactio:mainfrom Jun 29, 2021
Merged
Add name for each query and mutation in Hub Go client#378mszostok merged 2 commits intocapactio:mainfrom
mszostok merged 2 commits intocapactio:mainfrom
Conversation
pkosiec
approved these changes
Jun 29, 2021
Collaborator
|
This is OK change, I was able to confirm the issue on our stage cluster. The response in GraphQL Playground is terrible: query {
interfaces {
path
}
}results in: and query Interfaces {
interfaces {
path
}
}in: IMHO we should handle the issue #334 really soon. Also, on this PR I noticed another, very similar fail on integration tests: Another time empty error from GraphQL... I think we should spend more time on debugging this in a dedicated issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After bumping graphql-js dependency, the e2e tests are failing. After debugging, I detected that for all unnamed queries/mutations, the GraphQL API returns
400status code. Unfortunately, I cannot detect how our CI on PR didn't detect that.Changes proposed in this pull request: