Implement Secret storage backend as gRPC server#644
Merged
pkosiec merged 10 commits intocapactio:mainfrom Feb 28, 2022
Merged
Conversation
b5f2b6c to
795dd28
Compare
8 tasks
8af5f25 to
2c71d10
Compare
2c71d10 to
6474795
Compare
mszostok
reviewed
Feb 25, 2022
Collaborator
mszostok
left a comment
There was a problem hiding this comment.
I really enjoyed reviewing your PR, really nice work 👍
9b14085 to
397b49f
Compare
mszostok
approved these changes
Feb 26, 2022
| @@ -0,0 +1,315 @@ | |||
| package secretstoragebackend | |||
Collaborator
There was a problem hiding this comment.
Probably even earlier, as using the dotenvwill be useful in e2e tests, so we will need to add some padding to other task to figure this out or you can create a follow-up task to enable the Secret Store storage "consumption" by Local Hub.
Collaborator
Author
|
Integration tests failed during Capact iunstallation, but the previous run was successful (https://github.com/capactio/capact/actions/runs/1900095690) - and also this PR doesn't change anything related to integration tests, so I'm merging this without retry. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Changes proposed in this pull request:
dotenvprovider. Thevaultprovider needs to be testedTODO
dotenvproviders tellerops/teller#60)Notes
Lint failing because of timeout. Don't worry about it - The job will be green after review 🙂
Testing
To regenerate the gRPC code, run:
To run example calls against the gRPC service:
Create AWS security credentials with
SecretsManagerReadWritepolicy.Export environment variables:
Run the server:
Now let's use Go generated gRPC client to to see how the server behaves. Run the example
pkg/hub/api/grpc/storage_backend/example_test.go.To run it, you can e.g. change the
func ExampleNewStorageBackendClient() {tofunc TestE2EScenario(t *testing.T) {and run it as an usual test.Change the line 12 of this test and run it again:
Related issue(s)
Resolves #637