Skip to content

Install Test Storage Backend for Hub when USE_TEST_SETUP=true#655

Merged
pkosiec merged 6 commits intocapactio:mainfrom
pkosiec:storage-backend-for-testing
Mar 10, 2022
Merged

Install Test Storage Backend for Hub when USE_TEST_SETUP=true#655
pkosiec merged 6 commits intocapactio:mainfrom
pkosiec:storage-backend-for-testing

Conversation

@pkosiec
Copy link
Copy Markdown
Collaborator

@pkosiec pkosiec commented Mar 9, 2022

Description

Changes proposed in this pull request:

  • Install Test Storage Backend for Hub when USE_TEST_SETUP=true
  • Additional: Generate documentation for Populator

Notes

I will sync Populator docs in a follow-up PR to website. I will make sure they are visible on our website.

Testing

CI

You can observe capact-test-storage-backend-64d54d7c95-h4x9s pod in Run cross-functional integration tests (Nodes description section): https://github.com/capactio/capact/runs/5482807676?check_suite_focus=true

Manual

Build the CLI:

make build-tool-cli && mv ./bin/capact_darwin_amd64/capact /usr/local/bin

Run:

DISABLE_MONITORING_INSTALLATION=true USE_TEST_SETUP=true make dev-cluster

Do the port forwarding:

kubectl -n capact-system port-forward svc/capact-test-storage-backend 50051:50051

Run test:

GRPC_SECRET_STORAGE_BACKEND_ADDR=":50051" go test ./pkg/hub/api/grpc/storage_backend -run "^TestNewStorageBackendClient$" -v -count 1

Run test for default provider - it will fail:

GRPC_SECRET_STORAGE_BACKEND_ADDR=":50051" go test ./pkg/hub/api/grpc/storage_backend -run "^TestNewStorageBackendClient_WithDefaultProvider$" -v -count 1

Related issue(s)

#647

@pkosiec pkosiec added enhancement New feature or request WIP Work in progress area/hub Relates to Hub area/ci Relates to CI labels Mar 9, 2022
@pkosiec pkosiec removed the WIP Work in progress label Mar 9, 2022
@mkuziemko mkuziemko self-assigned this Mar 10, 2022
Copy link
Copy Markdown
Collaborator

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯 Comments added :)

Comment thread internal/frontmatter/format.go Outdated
Comment thread cmd/populator/cmd/register/register.go
Comment thread deploy/kubernetes/charts/capact/charts/test-storage-backend/Chart.yaml Outdated
@capactio capactio deleted a comment from github-actions Bot Mar 10, 2022
@capactio capactio deleted a comment from github-actions Bot Mar 10, 2022
@capactio capactio deleted a comment from github-actions Bot Mar 10, 2022
@capactio capactio deleted a comment from github-actions Bot Mar 10, 2022
@capactio capactio deleted a comment from github-actions Bot Mar 10, 2022
Copy link
Copy Markdown
Collaborator

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pkosiec pkosiec enabled auto-merge (squash) March 10, 2022 15:29
@pkosiec pkosiec merged commit 990d46b into capactio:main Mar 10, 2022
@pkosiec pkosiec deleted the storage-backend-for-testing branch March 10, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Relates to CI area/hub Relates to Hub enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants