Fix resolving backend.context in cypher#662
Merged
mszostok merged 2 commits intocapactio:mainfrom Mar 17, 2022
Merged
Conversation
b009adf to
1f1848e
Compare
pkosiec
approved these changes
Mar 15, 2022
Collaborator
pkosiec
left a comment
There was a problem hiding this comment.
LGTM with one improvement suggestion. If that's not something easy to do, let's skip it and merge this PR 👍
f26a757 to
20a0de7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
backend.contextin cypher. Currently, the context was always taken from the user input even if thebackendwas not sent. This against our contract, in case of empty backend we should use the oldbackend.contextUpdate scenario:
backendis not sent, use old settingsbackendwas sent, use newbackend.contextvalue (if it'snullthen persistnullwhich means, zerobackend.contextproperty)Testing
Run neo4j:
Run storage server:
Run Local Hub:
Run test:
You can also manually test that using GraphQL playground.