Implement Helm release storage backend#677
Merged
mszostok merged 5 commits intocapactio:mainfrom Mar 21, 2022
Merged
Conversation
0e2e24e to
e638a5b
Compare
pkosiec
approved these changes
Mar 21, 2022
Collaborator
pkosiec
left a comment
There was a problem hiding this comment.
Works well 👌 A few minor comments and this PR is ready to be merged 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related PR: capactio/hub-manifests#62. In backend, we have an assumption that the data is validated by Local Hub, so we receive a valid context with all required fields.
Testing
Setup
k3d cluster create testRUNNER_CONTEXT_PATH=cmd/helm-runner/example-input/context.yaml \ RUNNER_ARGS_PATH=cmd/helm-runner/example-input/install-args.yaml \ RUNNER_LOGGER_DEV_MODE=true \ RUNNER_COMMAND="install" \ go run cmd/helm-runner/main.goTesting
APP_LOGGER_DEV_MODE=true APP_MODE="release" go run ./cmd/helm-storage-backend/main.goThere is also unit test coverage.
Related issue(s)
Fix: #671