Skip to content

Implement Helm release storage backend#677

Merged
mszostok merged 5 commits intocapactio:mainfrom
mszostok:helm-storage/release
Mar 21, 2022
Merged

Implement Helm release storage backend#677
mszostok merged 5 commits intocapactio:mainfrom
mszostok:helm-storage/release

Conversation

@mszostok
Copy link
Copy Markdown
Collaborator

@mszostok mszostok commented Mar 17, 2022

Description

Changes proposed in this pull request:

  • Implement Helm release storage backend

Related PR: capactio/hub-manifests#62. In backend, we have an assumption that the data is validated by Local Hub, so we receive a valid context with all required fields.

Testing

Setup

  1. Create k8s cluster. For example, run:
    k3d cluster create test
  2. Install PostgreSQL Helm chart:
    RUNNER_CONTEXT_PATH=cmd/helm-runner/example-input/context.yaml \
     RUNNER_ARGS_PATH=cmd/helm-runner/example-input/install-args.yaml \
     RUNNER_LOGGER_DEV_MODE=true \
     RUNNER_COMMAND="install" \
     go run cmd/helm-runner/main.go

Testing

  1. Run server:
    APP_LOGGER_DEV_MODE=true APP_MODE="release" go run ./cmd/helm-storage-backend/main.go
  2. Run showcase test:
    GRPC_SECRET_STORAGE_BACKEND_ADDR=":50051" go test ./internal/helm-storage-backend/... -run "^TestShowcase$" -v -count 1

There is also unit test coverage.

Related issue(s)

Fix: #671

@mszostok mszostok added enhancement New feature or request WIP Work in progress area/hub Relates to Hub labels Mar 17, 2022
@mszostok mszostok removed the WIP Work in progress label Mar 20, 2022
@mszostok mszostok force-pushed the helm-storage/release branch from 0e2e24e to e638a5b Compare March 20, 2022 18:29
Copy link
Copy Markdown
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👌 A few minor comments and this PR is ready to be merged 🙂

Comment thread internal/helm-storage-backend/common.go Outdated
Comment thread pkg/runner/cloudsql/create.go
Comment thread internal/helm-storage-backend/release_test.go
Comment thread internal/helm-storage-backend/release.go Outdated
Comment thread internal/helm-storage-backend/release_test.go Outdated
Comment thread internal/helm-storage-backend/release_test.go
Comment thread internal/helm-storage-backend/release_test.go
@mszostok mszostok enabled auto-merge (squash) March 21, 2022 09:50
@mszostok mszostok merged commit dbaceea into capactio:main Mar 21, 2022
@mszostok mszostok deleted the helm-storage/release branch March 28, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hub Relates to Hub enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Helm release handler for Helm storage backend

2 participants