Update Content development guide#114
Merged
mkuziemko merged 8 commits intocapactio:mainfrom Mar 30, 2022
Merged
Conversation
mkuziemko
added
area/documentation
mkuziemko
commented
Mar 16, 2022
mkuziemko
commented
Mar 16, 2022
pkosiec
reviewed
Mar 17, 2022
Collaborator
pkosiec
left a comment
pkosiec
left a comment
There was a problem hiding this comment.
I really appreciate you updated the content in almost all places (e.g. removing mention of the Argo artifacts issue which is already resolved) 👍 Apart from some minor suggestions, the biggest things I'm missing are:
- a description of an Argo artifact content, that is: which properties it should have -
value,backendfields - to be able to upload it as a TypeInstance. I'm not seeing it anywhere 🤔 - a short, dedicated section how to use the storage backends from content developer perspective. I mean - really short and concise, so it shouldn't be a big deal 🙂
mkuziemko
force-pushed
the
update_guide
branch
2 times, most recently
from
9744eb7 to
b975ddd
Compare
pkosiec
reviewed
Mar 25, 2022
Collaborator
pkosiec
left a comment
pkosiec
left a comment
There was a problem hiding this comment.
Please make sure that all manifests are up to date according to our main branch on hub-manifests (including the unpackValue: true` from jinja) and apply all changes. Then it will be ready to be merged 👍
Co-authored-by: Paweł Kosiec <pawel.kosiec@gmail.com>
pkosiec
approved these changes
Mar 30, 2022
Collaborator
pkosiec
left a comment
pkosiec
left a comment
There was a problem hiding this comment.
Please apply last two comments and we can merge it 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Generally, I went through the whole text/examples and update it.
Related issue(s)