Mapping file issues

[keenk]

Ran into this a while back. Several entries in X86MappingInsnOp.inc appear to have incorrect values for operand read / write. Last time I was looking at this my understanding was that the .inc files are not generated by anything in the capstone project?

I have submitted a pull request #1256 to fix one example, but many more exist.

Similar issues in the .inc file are also likely the cause of #1255 and #1253

Test case:
Bytes: 66 0f 7f 01
Instruction: movdqa xmmword ptr [ecx], xmm0
Architecture: X86 32 bit

[aquynh]

more pull req, please ;-)

[E3V3A]

@keenk
Can you provide another PR for the remainders you mentioned?
(Or do you know someone else who can help?)

[keenk]

I'll have to try and carve out some time to look at the others. There are 401 other lines that I can see offhand to check. But those need to be looked at one by one.

[keenk]

Small amount of progress. Pull request #1295 fixes 3 of the issues.

Test cases:

movbe16mr
./cstool -d x16 "0F 38 F1 47 08"

movbe32mr
./cstool -d x32 "0F 38 F1 41 08"

movbe64mr
./cstool -d x64 "48 0F 38 F1 41 08"

[keenk]

These three fixes appear to have been (accidently?) rolled back in commit dd91f03 I have submitted pull request #1512 to re-fix them.