Integrate into travis cli#1378
Merged
aquynh merged 34 commits intocapstone-engine:masterfrom Feb 14, 2019
Merged
Conversation
Fix call to cstest -f issues.cs
fix build_cstest.sh to have proper install path on both MacOS & Linux
Contributor
|
#1355 can be closed after this pr being merged |
Collaborator
|
merged, thanks for this amazing work! |
Collaborator
that test-mc.sh is a bit different: it compares our output with LLVM, but actually LLVM is "wrong" on many cases. while cstest is to check with our verified output, and make sure we dont regress (with issues.cs) but we can close that #1355 if there is no longer mismatch. |
Contributor
|
But if we don't expect Capstone to match llvm's output (currently), the issue can be closed since the mismatching is expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.