respect libsuffix in pkgconfig#1393
Merged
aquynh merged 4 commits intocapstone-engine:masterfrom Feb 20, 2019
blshkv:patch-2
Merged
respect libsuffix in pkgconfig#1393aquynh merged 4 commits intocapstone-engine:masterfrom blshkv:patch-2
aquynh merged 4 commits intocapstone-engine:masterfrom
blshkv:patch-2
Conversation
blshkv
pushed a commit
to pentoo/pentoo-overlay
that referenced
this pull request
Feb 19, 2019
Collaborator
|
is it better to just use INSTALL_LIB_DIR? |
Contributor
Author
|
I have pushed a better patch. Basically, the entire lib64 detection was not working on x86 and it was installing it into lib64 on x86 anyway. I have included the standard GNUInstallDirs which provides all default dirs, you might want to review and remove INSTALL_LIB_DIR altogether. |
Collaborator
|
looks nice, please go ahead replacing all INSTALL_LIB_DIR. |
Collaborator
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
Feb 20, 2019
* respect libsuffix in pkgconfig discovered in https://bugs.gentoo.org/677946 * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt
aquynh
pushed a commit
that referenced
this pull request
Feb 20, 2019
* respect libsuffix in pkgconfig discovered in https://bugs.gentoo.org/677946 * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discovered in https://bugs.gentoo.org/677946