Skip to content

[M68K] store correct register value in op.reg_pair#1411

Merged
aquynh merged 2 commits intocapstone-engine:nextfrom
tmfink:m68k-reg-pair
Mar 2, 2019
Merged

[M68K] store correct register value in op.reg_pair#1411
aquynh merged 2 commits intocapstone-engine:nextfrom
tmfink:m68k-reg-pair

Conversation

@tmfink
Copy link
Copy Markdown
Contributor

@tmfink tmfink commented Mar 2, 2019

Fixes #1406

Also fixes a small type in the licensing text.


/* The code bellow is based on MUSASHI but has been heavily modified for Capstone by
/* The code below is based on MUSASHI but has been heavily modified for capstone by
* Daniel Collin <daniel@collin.com> 2015-2019 */
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why lowercase for "capstone" ;-?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an accident...

@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Mar 2, 2019

@emoon please ack.

tmfink added 2 commits March 1, 2019 23:57
Originally, value - M68K_REG_D0 was stored and the print logic added
M68K_REG_D0.
@emoon
Copy link
Copy Markdown
Contributor

emoon commented Mar 2, 2019

Looks good! Thanks for the fix

@aquynh aquynh merged commit 8ce800c into capstone-engine:next Mar 2, 2019
@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Mar 2, 2019

merged, thanks!

aquynh pushed a commit that referenced this pull request Mar 2, 2019
* m68k: store correct m68k_reg value in op.reg_pair

Originally, value - M68K_REG_D0 was stored and the print logic added
M68K_REG_D0.

* m68k: fix license typo
@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Mar 2, 2019

cherry-picked for "v4" branch, too.

@riptl riptl mentioned this pull request Jul 22, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants