Skip to content

MOS65XX: Use same output style as other archs#1445

Merged
aquynh merged 1 commit intocapstone-engine:masterfrom
s-macke:feature/mos65xx_style
Mar 24, 2019
Merged

MOS65XX: Use same output style as other archs#1445
aquynh merged 1 commit intocapstone-engine:masterfrom
s-macke:feature/mos65xx_style

Conversation

@s-macke
Copy link
Copy Markdown
Contributor

@s-macke s-macke commented Mar 23, 2019

Changed style according to #1439

Signed-off-by: Sebastian Macke sebastian@macke.de

Signed-off-by: Sebastian Macke <sebastian@macke.de>
@aquynh aquynh merged commit 472845d into capstone-engine:master Mar 24, 2019
@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Mar 24, 2019

merged, thanks!

@ksherlock
Copy link
Copy Markdown
Contributor

That doesn't look right. The 6502 family has historically used $ as the hexadecimal prefix, which is also standard for Motorola (and the M68K arch). There were some cross assembler that used 0x as a hexadecimal prefix but they are a minority. Using $0x is just wrong for everybody. Adding a space after the comma is also an odd choice. Many assembler wouldn't allow it. The M68K arch doesn't add extra spaces either.

@s-macke
Copy link
Copy Markdown
Contributor Author

s-macke commented Mar 27, 2019

Yes, I know. I mentioned my problems with my patch here: #1439
I am also not really happy about it.

I did the changes according to the patch for the M68K at cb4e1b9
and in comparison with the other Archs.

In the tests I have seen another arch with $0x as prefix. Hence I thought this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants