Python binding handling of bytearrays#1453
Merged
aquynh merged 1 commit intocapstone-engine:masterfrom Apr 3, 2019
ChrisDenton:python/bytearray
Merged
Python binding handling of bytearrays#1453aquynh merged 1 commit intocapstone-engine:masterfrom ChrisDenton:python/bytearray
aquynh merged 1 commit intocapstone-engine:masterfrom
ChrisDenton:python/bytearray
Conversation
Pass bytearrays by reference instead of copying to bytes.
Collaborator
|
cool, would you also send a pull req for Python docs at https://github.com/capstone-engine/capstone-engine.github.io/blob/master/lang_python.md? (which is for http://www.capstone-engine.org/lang_python.html) |
Collaborator
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
Apr 3, 2019
Pass bytearrays by reference instead of copying to bytes.
aquynh
pushed a commit
that referenced
this pull request
Apr 3, 2019
Pass bytearrays by reference instead of copying to bytes.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not very familiar with the capstone code but surely it would be better to pass bytearrays by reference instead of making a copy using
bytes? This can be done by passing the bytearray tofrom_bufferon the relevant ctype.