Skip to content

[next] Add cmake option to tell whether architectures should be included by default#1466

Merged
aquynh merged 1 commit intocapstone-engine:nextfrom
JornVernee:next_arch_default
Apr 29, 2019
Merged

[next] Add cmake option to tell whether architectures should be included by default#1466
aquynh merged 1 commit intocapstone-engine:nextfrom
JornVernee:next_arch_default

Conversation

@JornVernee
Copy link
Copy Markdown
Contributor

next branch port of #1463

@JornVernee JornVernee changed the title Add cmake option to tell whether architectures should be included by default [next] Add cmake option to tell whether architectures should be included by default Apr 29, 2019
@aquynh aquynh merged commit f4fd2d9 into capstone-engine:next Apr 29, 2019
@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Apr 29, 2019

merged, thanks!

@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Apr 29, 2019

i had to fix this:

  • chmod +x
  • add #!/bin/sh
  • add missing ;; after RISCV line
  • correct the check on input architecture

see 8216e8f

@JornVernee
Copy link
Copy Markdown
Contributor Author

@aquynh Ok, sorry about that. I used git bash to test the other PR, but kind of eye-balled this one (should have tested as well).

@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Apr 29, 2019 via email

@riptl riptl mentioned this pull request Jul 22, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants