fix for make.sh for android#1523
Merged
aquynh merged 2 commits intocapstone-engine:masterfrom Jul 26, 2019
Merged
Conversation
aquynh
reviewed
Jul 26, 2019
| } | ||
|
|
||
| CROSS="$TOOLCHAIN/bin/$CROSS" CFLAGS="--sysroot=$PLATFORM" LDFLAGS="--sysroot=$PLATFORM" ${MAKE} $* | ||
| #CC="${STANDALONE}/bin/clang" CFLAGS="--sysroot=${STANDALONE}/sysroot" ${MAKE} $* |
Collaborator
There was a problem hiding this comment.
please remove this commented out line.
Collaborator
|
merged, thanks! |
aquynh
reviewed
Jul 26, 2019
| ifeq ($(CROSS),) | ||
| RANLIB ?= ranlib | ||
| else ifeq ($(ANDROID), 1) | ||
| CC = $(CROSS)/../../bin/clang |
Collaborator
There was a problem hiding this comment.
is this a standard place for clang??
Contributor
Author
There was a problem hiding this comment.
Yes, I think so. $(CROSS)/../../bin/clang means ${STANDALONE}/bin/clang, in that dir, you can find all versions of clang, as the following:
root@xxx:~/workspace/capstone# ls android-ndk-arm64-android-21/bin/*clang*
android-ndk-arm64-android-21/bin/aarch64-linux-android-clang
android-ndk-arm64-android-21/bin/aarch64-linux-android-clang++
android-ndk-arm64-android-21/bin/aarch64-linux-android21-clang
android-ndk-arm64-android-21/bin/aarch64-linux-android21-clang++
...
...
aquynh
pushed a commit
that referenced
this pull request
Jul 26, 2019
* fix for make.sh for android * remove commented line
aquynh
pushed a commit
that referenced
this pull request
Jul 29, 2019
* fix for make.sh for android * remove commented line
6 tasks
|
/root/capstone/android-ndk-arm64-android-21/aarch64-linux-android/bingcc: not found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NDK=/path/to/the/unzipped/ndk/dir ./make.sh cross-android arm64 [clean]to test it. The build process is well but there is a problem formake test, the failure is because of the lack ofbingcc: