systemz: fix base/index printing#1561
Merged
aquynh merged 1 commit intocapstone-engine:nextfrom Nov 5, 2019
kamiyaa:next
Merged
systemz: fix base/index printing#1561aquynh merged 1 commit intocapstone-engine:nextfrom kamiyaa:next
aquynh merged 1 commit intocapstone-engine:nextfrom
kamiyaa:next
Conversation
Contributor
kamiyaa
commented
Oct 31, 2019
- In cases where base is 0 but index is not, Capstone doesn't print anything
- In cases where base is 0 but index is not, Capstone doesn't print anything
Contributor
|
There are tons of missing instructions and tons of outdated changes for sysz . The current state is useless for any use case i tried.. are you in the mood to update the sysz backend?
… On 31 Oct 2019, at 20:07, Jiayi Zhao ***@***.***> wrote:
In cases where base is 0 but index is not, Capstone doesn't print anything
You can view, comment on, or merge this pull request online at:
#1561
Commit Summary
systemz: fix base/index printing
File Changes
M arch/SystemZ/SystemZInstPrinter.c (9)
Patch Links:
https://github.com/aquynh/capstone/pull/1561.patch
https://github.com/aquynh/capstone/pull/1561.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Author
I don't mind. Is there someone I can refer to to get started/breakdown, or some documentation? |
Collaborator
|
@kamiyaa can you provide the input of this case? |
Contributor
Author
|
Expected: Actual: Expected: Actual: Expected: Actual: |
Collaborator
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
Nov 5, 2019
- In cases where base is 0 but index is not, Capstone doesn't print anything
aquynh
pushed a commit
that referenced
this pull request
Nov 5, 2019
- In cases where base is 0 but index is not, Capstone doesn't print anything
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.