Add cmake config and export targets.#1637
Merged
aquynh merged 1 commit intocapstone-engine:nextfrom Jun 2, 2020
mcmtroffaes:feature/cmake-config-targets
Merged
Add cmake config and export targets.#1637aquynh merged 1 commit intocapstone-engine:nextfrom mcmtroffaes:feature/cmake-config-targets
aquynh merged 1 commit intocapstone-engine:nextfrom
mcmtroffaes:feature/cmake-config-targets
Conversation
These additions simplify using capstone in cmake projects: find_package(capstone CONFIG REQUIRED) add_executable(main main.cpp) target_link_libraries(main PRIVATE capstone::capstone-static)
Contributor
Author
|
I figured this makes more sense for next rather than master, so I've rebased it. If next is the intended branch for pull requests, note that you can configure the default pull request branch in github (settings -> branches -> default branch). |
Collaborator
|
merged, thanks! |
Contributor
Author
|
Thanks so much! Could this be backported to master as well? Happy to create a pull request for it. Or will next be merged into master soon? |
Collaborator
|
i am thinking about merging next to master. |
Contributor
|
@aquynh should there even a master branch at this point? Why not just have next, v2, v3, and so on? |
Contributor
|
on a separate note, I think there should be developer documentation explaining the purpose of the "mainline" branches and the release model |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates a few more files on install to add support for cmake's find_package system, thereby simplifying the use of capstone in cmake projects, for instance:
Also see CMakePackageConfigHelpers. Tested with Visual Studio 2019 and CMake 3.17 using the following code for
main.cpp: