Fix bug introduced in commit 0932f167fd5620bba1619fc3fae90924292ebb2e#1681
Merged
aquynh merged 1 commit intocapstone-engine:masterfrom Mar 7, 2021
Merged
Conversation
Contributor
|
Can you please create a new PR on libcapstone? |
Collaborator
|
merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0932f16 a fix was submitted to remove the repne/repnz prefix from movs instructions with SSE registers. However, the change checks for X86_MOVSW rather than X86_MOVSL (movsd).
This breaks a simple repne movsd instruction:
want:
0: f2 a5 repnz movs DWORD PTR es:[edi],DWORD PTR ds:[esi]
got:
0: f2 a5 movs DWORD PTR es:[edi],DWORD PTR ds:[esi]
Clearly, the f2 prefix is dropped, even though it should be present.