Merged
Conversation
We do not want to append the entire string, only the single non-argument character. Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
While upstream LLVM probably has a tablegen thing for these somewhere, the current import doesn't include them. Take the list from riscv-privileged-v1.10.pdf. Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Contributor
|
@rth7680 Great. That is exactly what I encountered when testing the RISC-V implementation yesterday. The Python binding fails to parse the resulting string as ASCII and therefore fails too. I hope this gets merged soon. |
Contributor
|
Can you please create a new PR on libcapstone? |
pranith
approved these changes
Mar 5, 2021
Contributor
|
@aquynh LGTM. Please merge. |
Collaborator
|
merged, thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes e.g.
which currenly prints non-ascii garbage
which is a combination of printing nothing at all for the csr, and erroneously printing internal operand numbers for aliases.