mos65xx: use address on mem operands for relative addressing#1702
Merged
aquynh merged 3 commits intocapstone-engine:nextfrom Mar 10, 2021
Merged
mos65xx: use address on mem operands for relative addressing#1702aquynh merged 3 commits intocapstone-engine:nextfrom
aquynh merged 3 commits intocapstone-engine:nextfrom
Conversation
using the wrong field works on little-endian hosts, but on big-endian the wrong value would be read
previously the last operand would have an offset, which doesn't match the printed operand
this demonstrates an address operand with relative addressing
Contributor
Author
|
Looks like the fuzz test is failing due to the fancy quotes in |
Contributor
|
Can you please create a new PR on libcapstone? |
Collaborator
|
@s-macke please can you ack? |
Contributor
|
The first commit fixes one obvious bug. For the second commit I compared the current output with other architectures. They all use absolute addresses for relative branches. So the commit if fine for me. Acknowledged |
Collaborator
|
merged, thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how the
memfield is used in relative addressing:Previously, the last operand would show the offset as it's encoded in the instruction, instead of the address, which doesn't match what is printed:
Now, it shows the matching address for all operands:
An alternative to this solution would be using a different operand type (not MEM) for relative addressing, or using a structure to indicate if the address is absolute or relative.
Also, a small fix of setting
imminstead ofmem, which would return wrong values when running on big endian hosts.