Merged
Conversation
* groups constants by enum * use pascal case for enum names * use camel case for enum values * values are always literals * add extra options for some enums * use different types for some enums * generate option sets instead of enums for some types * renaming constants according to regex pattern
Contributor
|
Would be a perfect addition to a possible "capstone-project" GitHub organization if @aquynh decides to make it happen: #1319 (comment) |
Collaborator
|
merged, thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on a Capstone binding for Swift: capstone-swift.
Due to how Swift packages work, it must be in its own repository.
This required some additions to the const generator script to map constants in a more swift-like way:
These changes don't affect other bindings, but if it's inconvenient to have so much code in the const generator script only for Swift, I can keep it in my own repo.