Skip to content

Fixes the (pip) Python Module build on FreeBSD.#1750

Merged
aquynh merged 1 commit intocapstone-engine:masterfrom
cederom:cederom-freebsd-python-module-build-fix
May 11, 2021
Merged

Fixes the (pip) Python Module build on FreeBSD.#1750
aquynh merged 1 commit intocapstone-engine:masterfrom
cederom:cederom-freebsd-python-module-build-fix

Conversation

@cederom
Copy link
Copy Markdown

@cederom cederom commented May 11, 2021

This fixes the manual and pip Python Module build on FreeBSD.

FreeBSD distinguishes make (BSD) vs gmake (GNU) so cmake + bsd make needs to be used.

Although FreeBSD provides capstone system packages, this module will build and install its own C extensions.

capstone-build-fixed.txt
capstone-build-fixed-tests.txt

Signed-off-by: Tomasz 'CeDeROM' CEDRO tomek@cedro.info

Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented May 11, 2021

merged, thanks!

@cederom
Copy link
Copy Markdown
Author

cederom commented May 11, 2021

Thank you @aquynh :-) When next release is planned so we could have it working out of the box with pip? :-)

@cederom
Copy link
Copy Markdown
Author

cederom commented Jan 23, 2022

@aquynh can you please create a new release? pip still fails on the BSD because there has been no release since patch was provided..

@aquynh
Copy link
Copy Markdown
Collaborator

aquynh commented Jan 23, 2022 via email

@cederom
Copy link
Copy Markdown
Author

cederom commented Jan 23, 2022

Thank you @aquynh 5.0 is fine too.. can I help anyhow? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants