Fix compilation warnings related to TriCore.#2012
Merged
aquynh merged 2 commits intocapstone-engine:nextfrom May 9, 2023
Merged
Fix compilation warnings related to TriCore.#2012aquynh merged 2 commits intocapstone-engine:nextfrom
aquynh merged 2 commits intocapstone-engine:nextfrom
Conversation
Contributor
|
@trufae could you please test this one? |
XVilka
approved these changes
May 5, 2023
Contributor
|
@imbillow if you write |
Contributor
|
Looks good, no warnings for me |
Collaborator
|
dont you want to include |
trufae
reviewed
May 8, 2023
| #ifndef CAPSTONE_CSTOOL_CSTOOL_H_ | ||
| #define CAPSTONE_CSTOOL_CSTOOL_H_ | ||
|
|
||
| void print_insn_detail_x86(csh ud, cs_mode mode, cs_insn *ins); |
Contributor
There was a problem hiding this comment.
Arent these definitions depending on ifdefs for each selected arch? I think those must be wrapped around ifdefs
Contributor
Author
There was a problem hiding this comment.
But cstool uses cs_support(CS_ARCH_XXX) to query capstone for architectural support, not conditional compilation.
Member
There was a problem hiding this comment.
Hi, can this thread be marked as solved?
XVilka
approved these changes
May 8, 2023
Contributor
Collaborator
|
merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2009