[ARM] Fix VFP feature check#2090
Merged
aquynh merged 1 commit intocapstone-engine:v5from Jul 18, 2023
Merged
Conversation
VFP instructions could only be disassembled if armv8 was set as arch. This is because the predicate fails due to this feature check. This is incorrect as also armv7 can have VFP support.
5 tasks
XVilka
approved these changes
Jul 18, 2023
Collaborator
|
merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM VFP instructions could not be disassembled if
arch != armv8. This happens because of a faulty feature check. The check assumes VFP isv8only.This is not the case as can be checked with LLVM: