Add general encoding information for instructions#2231
Closed
Rot127 wants to merge 4 commits intocapstone-engine:nextfrom
Closed
Add general encoding information for instructions#2231Rot127 wants to merge 4 commits intocapstone-engine:nextfrom
Rot127 wants to merge 4 commits intocapstone-engine:nextfrom
Conversation
This was referenced Jan 3, 2024
47 tasks
github-actions
bot
added
ARM
Collaborator
Author
|
@AngelDev06 Any objections against this (cff87a3) naming convention? |
Merged
|
@Rot127 None. I like it more than my version, which was a little rushed. It's better that you can now refer to the documentation rather than trying to make sense from comments. |
Collaborator
Author
|
Closed due to: #2045 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the encoding information for each instruction. @AngelDev06 did the first implementation in #2045
This PR adds a few changes:
RenameARM_MEM_FMTto something ISA or LLVM related. The current names are rather arbitrary and don't relate to the formatting as described in the ISA or LLVM definitions. Which makes it difficult to determine which encoding corresponds to which one in the ISA.Add an enum for ISA instruction formats for ARM (if possible). According toC2.1(documentDDI0553B.v)Generate for all other archs the encoding.