[Auto-Sync] LLVM 18 update#2296
Merged
kabeor merged 41 commits intocapstone-engine:nextfrom Apr 22, 2024
Merged
Conversation
912378f to
038e1af
Compare
Collaborator
Author
|
@kabeor Also please take a look at this one. I will add more tests, but implement them together with the arch updates (each in separated PRs). But this makes already many changes. No need to stack them indefinitely. |
Collaborator
Author
|
@kabeor When you merge, please squash and use the commit message from above |
Building the tree-sitter-cpp library on our own will be removed in py-tree-sitter v0.22.0. As long as the tree-sitter-cpp doesn;t have Python bindings (see: tree-sitter/tree-sitter-cpp#250) we have to stick to <0.22.0
… version is used.
Collaborator
Author
|
@kabeor Can you please take a look at it. It does a lot of clean ups. |
This was referenced Apr 7, 2024
Member
|
Thanks a lot. I have started the review, will done asap. |
kabeor
approved these changes
Apr 22, 2024
Member
|
Really nice! Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQUASH ME
commit message:
Your checklist for this pull request
Detailed description
For now only fixups and tests for the AS scripts. No changes to the archs
Add a Capstone diet build testWith arch updates.Test plan
CI green
Closing issues
...