[next] Updates and fixes to the Python wheel builder workflow#2441
Merged
kabeor merged 5 commits intocapstone-engine:nextfrom Aug 15, 2024
Merged
[next] Updates and fixes to the Python wheel builder workflow#2441kabeor merged 5 commits intocapstone-engine:nextfrom
kabeor merged 5 commits intocapstone-engine:nextfrom
Conversation
- Win32 never builds a 32bit binary. - Linux AArch64 is build for undefined platform manylinux1_aarch64 (pypa/cibuildwheel#1972)
This reverts commit b0573b7.
kabeor
approved these changes
Aug 15, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Fixes several issues with the binaries in the Python wheels:
x86_64,AArch64anduniversal2(AArch64,x86_64).Win32build is removed becausecibuildwheeldoesn't set the relevant build flags and I currently don't want to put the effort in a basically EOL platform (people can easily build it themselves).manylinux1_aarch64is an undefined platform but gets built pypa/cibuildwheel#1972Test plan
Added
Closing issues
closes #2154
closes #2102