AArch64: Replace vararg add_cs_detail by multiple concrete functions#2507
Merged
Rot127 merged 1 commit intocapstone-engine:nextfrom Oct 22, 2024
Merged
AArch64: Replace vararg add_cs_detail by multiple concrete functions#2507Rot127 merged 1 commit intocapstone-engine:nextfrom
Rot127 merged 1 commit intocapstone-engine:nextfrom
Conversation
thestr4ng3r
force-pushed
the
no-varargs-aarch64
branch
2 times, most recently
from
b60b6eb to
ae46dbe
Compare
Rot127
requested changes
Oct 14, 2024
thestr4ng3r
force-pushed
the
no-varargs-aarch64
branch
from
ae46dbe to
2d15c75
Compare
Contributor
Author
|
Added. Keep in mind the bug in the original code does not manifest itself on current mainstream architectures. |
Collaborator
Yes, I am aware. But I want to have it in case someone starts using Capstone on another weird machine. So just general test case coverage. |
Rot127
approved these changes
Oct 17, 2024
kabeor
approved these changes
Oct 19, 2024
Fixes UB caused by various mismatches on how these arguments are passed and read. This became visible when running on PowerPC hosts with e.g. `cstool -d aarch64 204862f8`. Apart from the UB fix, this is meant to be a pure refactor. Partially addresses capstone-engine#2458
thestr4ng3r
force-pushed
the
no-varargs-aarch64
branch
from
2d15c75 to
1d13a12
Compare
Contributor
Author
|
Sure, rebased now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Fixes UB caused by various mismatches on how these arguments are passed and read. This became visible when running on PowerPC hosts with e.g.
cstool -d aarch64 204862f8.Apart from the UB fix, this is meant to be a pure refactor.
Test plan
see #2458 (comment)
Closing issues
Partially addresses #2458
Mips, PPC and Xtensa still have potentially problematic varargs.