Fix sdist build and add CI job for testing it.#2622
Closed
Rot127 wants to merge 2 commits intocapstone-engine:nextfrom
Closed
Fix sdist build and add CI job for testing it.#2622Rot127 wants to merge 2 commits intocapstone-engine:nextfrom
Rot127 wants to merge 2 commits intocapstone-engine:nextfrom
Conversation
github-actions
Bot
added
Python
2 tasks
Rot127
force-pushed
the
cmake-cpack-build-fix
branch
2 times, most recently
from
8a88a38 to
bb1ef07
Compare
Rot127
force-pushed
the
cmake-cpack-build-fix
branch
from
bb1ef07 to
c774ad7
Compare
Rot127
force-pushed
the
cmake-cpack-build-fix
branch
from
a279539 to
ec3aa8a
Compare
Antelox
reviewed
Feb 12, 2025
| @@ -264,6 +272,14 @@ jobs: | |||
| name: sdist-archive | |||
| path: bindings/python/dist/*.tar.gz | |||
Contributor
There was a problem hiding this comment.
It should be enough to add the following line:
python3 -m pip install dist/*.tar.gz
instead of the section added below
Antelox
reviewed
Feb 12, 2025
| - name: '🛠️ Set up QEMU' | ||
| if: runner.os == 'Linux' && matrix.arch != 'x86_64' | ||
| uses: docker/setup-qemu-action@v3 | ||
| with: |
Contributor
There was a problem hiding this comment.
IMHO it's better doing this change in a separate PR
Collaborator
Author
|
@Antelox As discussed given to you, |
This was referenced Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Addresses #2621 on the v6 branch.
The
sdistbuild was not tested before. Hence we didn't detect issues with it.This fixes the build (missing files in
sdistarchive) and adds a new test for it as job.It also adds a
CAPSTONE_BUILD_FUZZERflag. Because thesdistdoesn't include any testing tools. So the fuzzer source should be excluded.Test plan
Added
Closing issues
...