Add workflow for building on Windows#2675
Merged
kabeor merged 2 commits intocapstone-engine:nextfrom Apr 9, 2025
stevenjoezhang:next
Merged
Add workflow for building on Windows#2675kabeor merged 2 commits intocapstone-engine:nextfrom stevenjoezhang:next
kabeor merged 2 commits intocapstone-engine:nextfrom
stevenjoezhang:next
Conversation
Collaborator
|
The build fails when I do a test release. See: https://github.com/Rot127/capstone/actions/runs/14291716748/job/40053779251 |
Rot127
reviewed
Apr 6, 2025
Collaborator
There was a problem hiding this comment.
Tested already with a previous version and it was fine. Also installing with a Windows VM and running cstool worked out.
Will test a last time once all is green. This would be also the last PR before we release Alpha4. So if you have any last additions...
Contributor
Author
|
I think there are two issues here:
Both of these issues have now been fixed. See https://github.com/stevenjoezhang/capstone/actions/runs/14293644558 |
Collaborator
|
You can ignore the failing test. |
Collaborator
|
Can you quickly press the rebase button please. Just so the test is green. |
kabeor
pushed a commit
that referenced
this pull request
Apr 9, 2025
* Add workflow for building on Windows * Fix build
Rot127
pushed a commit
that referenced
this pull request
Apr 11, 2025
* Add workflow for building on Windows * Fix build
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
See #2674
Test plan
You can checkout the workflow on my forked version: https://github.com/stevenjoezhang/capstone/actions/runs/14284910369
An installer is available for download
Closing issues
Closes #2153