Skip to content

Tblgen capstone backends AArch64#10

Merged
kabeor merged 36 commits intocapstone-engine:auto-syncfrom
Rot127:tblgen_capstone_backends_aarch64
Jun 18, 2023
Merged

Tblgen capstone backends AArch64#10
kabeor merged 36 commits intocapstone-engine:auto-syncfrom
Rot127:tblgen_capstone_backends_aarch64

Conversation

@Rot127
Copy link
Copy Markdown
Collaborator

@Rot127 Rot127 commented May 20, 2023 •
edited
Loading

Base on #9

@wargio

This comment was marked as resolved.

Sign in to view
@Rot127
Copy link
Copy Markdown
Collaborator Author

Rot127 commented May 20, 2023 •
edited
Loading

@wargio It's based on the PPC PR mentioned above, because I made some changes there I'd like to have here as well.
So the PRs must be merged in this order: ARM (done) -> PPC -> AArch64

@XVilka
Copy link
Copy Markdown
Collaborator

XVilka commented May 23, 2023

@Rot127 do we have a list of incomplete TableGen instructions descriptions that we can report to LLVM mainstream?
I wonder if they might want to update it.

@Rot127
Copy link
Copy Markdown
Collaborator Author

Rot127 commented May 23, 2023 •
edited
Loading

do we have a list of incomplete TableGen instructions descriptions that we can report to LLVM mainstream?

We can simply cherry-pick the commits which fix incorrect properties and create a revision for them. But I think it is better to wait until we release CS v6. So more people had the chance to find possibly more problems with the definitions.

But in the tracking issue is a column for this.

This was referenced May 25, 2023
Closed
Merged
@Rot127 Rot127 force-pushed the tblgen_capstone_backends_aarch64 branch from f592bc3 to d47c749 Compare May 30, 2023 13:19
@Rot127 Rot127 mentioned this pull request May 30, 2023
Closed
@XVilka
Copy link
Copy Markdown
Collaborator

XVilka commented Jun 1, 2023

@Rot127 as PPC PR was merged, please rebase this one to resolve conflicts

Rot127 added 21 commits June 2, 2023 07:36
@Rot127
Add documentation.
2b274c3
@Rot127
Handle special AArch64 operand
db43672
@Rot127
Replace C++ with C code.
eb0f7fe
@Rot127
Check for duplicate enum instr. names
8bd6706
@Rot127
Check for duplicate defintions of system registers.
1778df7
@Rot127
Add note about missing target names.
2e74035
@Rot127
Resolve templates in a single static method and add docs about it.
190d42a
@Rot127
Revert printing target name in upper case.
c9f2924
@Rot127
Revert partially C++ syntax fixes in .td files.
53d29d2 
They break the TemplateCOllector since it searches for exactly those references but can't find any'
@Rot127
Add all SubtargetFeatures to feature enum.
35574db 
Not just the one used by CGIs.
@Rot127
Pass Decoder
18ca643
@Rot127
Enable to check specific table fields to determine if reg enum must b…
0a0c877 
…e emitted.
@Rot127
Allow to add namespace to type name/
2ced972
@Rot127
Formatting
35265a1
@Rot127
Rework emitting of tables.
1d69a1b 
The system operands are now emitted in reg, imm and aliass groups.
Also a bug was fixed which emitted incorrect code..
@Rot127
Check for rename IMPLICIT_IMM operand types
69bc7d1
@Rot127
Pass DecodeComplete as pointer not as reference
2f17488
@Rot127
Print undef when it needs to be printed.
ae6f7eb
@Rot127
Add namespace ids to all types and functions.
37ada75
@Rot127
Rework C translation.
fe28fc2
@Rot127
Pass MCOp as pointer not as ref
b17901c
@Rot127 Rot127 force-pushed the tblgen_capstone_backends_aarch64 branch from ecc4465 to 59f679e Compare June 2, 2023 12:37
@Rot127 Rot127 mentioned this pull request Jun 5, 2023
Open
47 tasks
@Rot127 Rot127 marked this pull request as ready for review June 18, 2023 14:29
@Rot127
Copy link
Copy Markdown
Collaborator Author

Rot127 commented Jun 18, 2023 •
edited
Loading

@kabeor Please let us merge this before the ARM PR. Because this contains updated documentation about the backends. Also we can rebase it ontop the newest 16.x release.

@kabeor
Copy link
Copy Markdown
Member

kabeor commented Jun 18, 2023

Sure, merged.

@kabeor kabeor merged commit b47de4d into capstone-engine:auto-sync Jun 18, 2023
@Rot127
Copy link
Copy Markdown
Collaborator Author

Rot127 commented Jun 18, 2023

This was quick :D

@R33v0LT R33v0LT mentioned this pull request Jul 2, 2023
Merged
@Rot127 Rot127 deleted the tblgen_capstone_backends_aarch64 branch August 22, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rot127 @wargio @XVilka @kabeor