Remove tPOP and tPUSH as real isntructions.#39
Closed
Rot127 wants to merge 1 commit intocapstone-engine:auto-syncfrom
Closed
Remove tPOP and tPUSH as real isntructions.#39Rot127 wants to merge 1 commit intocapstone-engine:auto-syncfrom
Rot127 wants to merge 1 commit intocapstone-engine:auto-syncfrom
Conversation
push and pop are techincally no real instructions but alias of stm and ldr. Also they are encoding wise the same as their Thumb2 variants. Hence, they should be removed as real instructions.
47 tasks
Collaborator
Author
|
Turns out Thumb1 16bit pop and push are actually defined as instructions and not as alias. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
push and pop are techincally no real instructions but alias of stm and ldr. Also they are encoding wise the same as their Thumb2 variants. Hence, they should be removed as real instructions.